This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix bad PhysicalShapeLayer performance when using system_composite#15320
Closed
arbreng wants to merge 1 commit into
Closed
Fix bad PhysicalShapeLayer performance when using system_composite#15320arbreng wants to merge 1 commit into
arbreng wants to merge 1 commit into
Conversation
Contributor
Author
|
the parts I deleted were left over from a bad merge in #14577 |
gaaclarke
reviewed
Jan 8, 2020
| set_paint_bounds(path_.getBounds()); | ||
| } else { | ||
| if (PhysicalShapeLayerBase::can_system_composite()) { | ||
| // always system composite these layers when possible and an elevation is |
Contributor
There was a problem hiding this comment.
Comments should be proper prose: https://google.github.io/styleguide/cppguide.html#Punctuation,_Spelling_and_Grammar
Contributor
|
Can you supply some data to justify the change? Maybe a performance test? Maybe a skia trace? |
Contributor
|
@gaaclarke fxb/43364 has traces relating to this regression |
iskakaushik
approved these changes
Jan 9, 2020
iskakaushik
left a comment
iskakaushik
left a comment
Contributor
There was a problem hiding this comment.
LGTM given that this addresses a high priority regression and that this change has been tested manually on various environments.
Contributor
Author
|
Unfortunately this ended up not being a fix in all situations, based on traces in the linked fxb/ issue. Going to make another PR with a targeted revert of the offending code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.